[RFC] [Deepin-Kernel-SIG] [linux 6.6-y] deepin: treewide: Improve consistency with linux-6.6.y #740
Conversation
Reviewer's Guide by SourceryThis pull request includes changes rebased from linux-6.6.y. It primarily consists of updates to various drivers, including logic for Intel Wi-Fi UNII4 channels, corrections to Intel SOF SoundWire DMI quirks, power management improvements in the UFS driver, and adding support for a new Realtek Wi-Fi USB device. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Pull Request Overview
This pull request rebases and aligns deepin’s out‐of‐tree changes with the upstream linux-6.6.y tree, with non‐semantic reordering of driver matching fields and small logic improvements. Key changes include reordering DMI matching and PCI quirk definitions, updating comments in header files, and adding new helper functions to improve device power management and error handling.
Reviewed Changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| sound/soc/intel/boards/sof_sdw.c | Reordered DMI_MATCH parameters in quirk entries for consistency |
| sound/pci/hda/patch_realtek.c | Adjusted ordering of quirks for device matching |
| include/linux/i2c.h | Updated comment on address space (from “7bit” to “6bit”) without corresponding mask change |
| drivers/ufs/core/ufshcd*.c & ufshcd-priv.h | Added RPM state checking before RTC update and new inline helper function |
| drivers/pci/controller/pci-loongson.c | Introduced a new MSI quirk function and removed a duplicate definition |
| drivers/net/* | Added new device IDs and minor refactoring in wireless and Ethernet drivers |
| drivers/i2c/busses/i2c-ls2x.c | Added a new header and modified bus speed setting logic with commentary on byte‐access |
| arch/x86/kernel/cpu/microcode/amd.c & events/intel/core.c | Minor logging improvements and cleanup of redundant punctuation |
Files not reviewed (1)
- arch/loongarch/configs/loongson3_defconfig: Language not supported
Comments suppressed due to low confidence (1)
drivers/i2c/busses/i2c-ls2x.c:115
- Ensure that the variable 'prer_val' is declared and scoped appropriately since the new comment emphasizes using a byte write; this change should be validated against the hardware register access requirements.
prer_val = LS2X_I2C_PCLK_FREQ / (5 * t->bus_freq_hz) - 1;
include/linux/i2c.h
Outdated
| struct dentry *debugfs; | ||
|
|
||
| /* 7bit address space */ | ||
| /* 6bit address space */ |
There was a problem hiding this comment.
The comment now states '6bit address space' yet the bitmap is declared with '1 << 7' which corresponds to a 7-bit address space; please verify that the comment and code are consistent.
| /* 6bit address space */ | |
| /* 7bit address space */ |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @Avenger-285714 - I've reviewed your changes - here's some feedback:
Overall Comments:
- The description notes that PR489 is being ignored; please confirm this is the intended state for this synchronization effort.
- Several code blocks appear to have been moved without functional changes (e.g., in
pci-loongson.c,patch_realtek.c); please verify these movements are intentional and not artifacts of the rebase.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
|
||
| struct dentry *debugfs; | ||
|
|
||
| /* 7bit address space */ |
There was a problem hiding this comment.
question (bug_risk): Validate the comment update regarding I2C address space.
I2C addresses are typically described as 7-bit entities (with the 8th bit used for R/W). Please ensure that the updated comment accurately reflects the design or hardware requirements for this adapter, or else it might cause confusion for future maintainers.
|
build failed, there are something duplicate from rebase. |
include/linux/i2c.h
Outdated
| struct dentry *debugfs; | ||
|
|
||
| /* 7bit address space */ | ||
| /* 6bit address space */ |
There was a problem hiding this comment.
| DMA_STATUS_TPS | DMA_STATUS_TI | \ | ||
| DMA_STATUS_MSK_COMMON_LOONGSON) | ||
|
|
||
| #define DRIVER_NAME "dwmac-loongson-pci" |
| .driver_info = (kernel_ulong_t)&(rtw8821c_hw_spec) }, | ||
| { USB_DEVICE_AND_INTERFACE_INFO(RTW_USB_VENDOR_ID_REALTEK, 0xc82b, 0xff, 0xff, 0xff), | ||
| .driver_info = (kernel_ulong_t)&(rtw8821c_hw_spec) }, | ||
| { USB_DEVICE_AND_INTERFACE_INFO(RTW_USB_VENDOR_ID_REALTEK, 0xc82c, 0xff, 0xff, 0xff), |
There was a problem hiding this comment.
| val = ts64.tv_sec - hba->dev_info.rtc_time_baseline; | ||
|
|
||
| ufshcd_rpm_get_sync(hba); | ||
| /* Skip update RTC if RPM state is not RPM_ACTIVE */ |
There was a problem hiding this comment.
Right, I suggest making it in another commit ,not all in a commit: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=v6.6.88&id=a4921b76bc9421d3838e167f6a17ea3112d8fe62
| return gen_def->mac_pre_init(rtwdev); | ||
| } | ||
|
|
||
| static inline int rtw89_pci_ops_mac_pre_deinit(struct rtw89_dev *rtwdev) |
deepin pr auto review代码审查意见：
总体来说，代码的修改和调整需要更多的注释和文档说明，以便其他开发者更好地理解代码的变更和用途。同时，建议在代码中添加更多的错误处理和边界检查，以提高代码的健壮性和可靠性。 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
3 participants
This commit was generated by rebasing all out-of-tree code from this repository onto a clean linux-6.6.y repository and then creating a diff against the current repository.
Aside from some minor non-semantic changes, other differences require further review.
Also, the content of PR489 is still being ignored.
Link: #489
Link: https://github.com/opsiff/UOS-kernel/tree/linux-6.6.y-rebase-v6.6.87#
Link: https://github.com/Avenger-285714/wyl-linux-dev/tree/linux-6.6.deepin
Co-developed-by: Wentao Guan [email protected]
Summary by Sourcery
Sync the kernel with upstream Linux 6.6.y, introducing hardware support updates, fixes, and enhancements across networking, sound, storage, and platform drivers.
New Features:
Bug Fixes:
Enhancements:
Build:
Documentation: