fix(pt): remove optimizer state from multi-task change-bias to reduce file size#4954
Draft
fix(pt): remove optimizer state from multi-task change-bias to reduce file size#4954
Conversation
…cted branch Co-authored-by: njzjz <[email protected]>
Copilot
AI
changed the title
[WIP] [BUG]
fix(pt): optimize change-bias for multi-task models to save only selected branch
Sep 3, 2025
dp change-bias will give much large model
Member
|
@copilot The original issue is not fixed. Reproduce: Go to |
… file size Co-authored-by: njzjz <[email protected]>
Contributor
Author
I've reproduced and fixed the issue. The problem was that the previous fix was still including the optimizer state from the original multi-task model, which took up most of the file size. The fix now excludes optimizer state for multi-task models, resulting in a 70% file size reduction (27MB → 7.9MB in the test case). Fixed in commit 5028e76. |
Copilot
AI
changed the title
fix(pt): optimize change-bias for multi-task models to save only selected branch
fix(pt): remove optimizer state from multi-task change-bias to reduce file size
Sep 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue where
dp --pt change-biascreates unnecessarily large model files for multi-task models and requires head selection when loading the resulting model.Problem
When using
dp --pt change-biason multi-task models, two issues occurred:numb_steps: 0For example, a 27MB multi-task model would produce a 26MB output file after change-bias, when it should produce a ~8MB single-head model like fine-tuning does.
Root Cause
The
change_biasfunction indeepmd/pt/entrypoints/main.pywas:Solution
Modified the saving logic to:
train_infosand other required metadataResults
numb_steps: 0The fix ensures that
dp --pt change-biason multi-task models produces appropriately sized single-head models that can be used directly without head selection.Fixes #4348.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.