Skip to content

fix: pass mixed_type to eval_descriptor in cli#5177

Merged
wanghan-iapcm merged 1 commit intodeepmodeling:masterfrom
njzjz:fix-5176
Jan 27, 2026
Merged

fix: pass mixed_type to eval_descriptor in cli#5177
wanghan-iapcm merged 1 commit intodeepmodeling:masterfrom
njzjz:fix-5176

Conversation

@njzjz
Copy link
Member

@njzjz njzjz commented Jan 26, 2026

Fix #5176.

Summary by CodeRabbit

  • Bug Fixes
    • Fixed mixed_type parameter not being properly forwarded during descriptor evaluation, ensuring the flag is now correctly propagated through the evaluation process.

✏️ Tip: You can customize this high-level summary in your review settings.

Copilot AI review requested due to automatic review settings January 26, 2026 17:26
@dosubot dosubot bot added the bug label Jan 26, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 26, 2026

📝 Walkthrough

Walkthrough

The change adds the mixed_type parameter to the dp.eval_descriptor() call in the eval_desc entrypoint, ensuring the mixed_type flag is properly forwarded during descriptor evaluation.

Changes

Cohort / File(s) Summary
Parameter forwarding
deepmd/entrypoints/eval_desc.py
Added mixed_type=mixed_type argument to dp.eval_descriptor() call to propagate the mixed_type flag from entrypoint to the descriptor evaluation function

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested labels

Python

Suggested reviewers

  • wanghan-iapcm
  • iProzd
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: passing the mixed_type parameter to eval_descriptor in the CLI, which directly addresses the bug fix objective.
Linked Issues check ✅ Passed The code change forwards mixed_type to eval_descriptor, directly addressing issue #5176's requirement to handle deepmd/npy/mixed format inputs with multiple frames without ValueError.
Out of Scope Changes check ✅ Passed The single line change is narrowly scoped to forwarding the mixed_type parameter as required by the linked issue, with no extraneous modifications or unrelated logic changes.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request fixes a bug in the dp eval-desc command where the mixed_type parameter was not being passed to the eval_descriptor method, causing a ValueError when processing deepmd/npy/mixed format MultiSystems with multiple frames.

Changes:

  • Added mixed_type=mixed_type parameter to the dp.eval_descriptor() call in the CLI entrypoint

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@njzjz njzjz requested a review from wanghan-iapcm January 26, 2026 17:49
@njzjz
Copy link
Member Author

njzjz commented Jan 26, 2026

@QuantumMisaka could you test this PR? Thanks!

@codecov
Copy link

codecov bot commented Jan 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.95%. Comparing base (e8afb6e) to head (b7c04d9).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5177   +/-   ##
=======================================
  Coverage   81.95%   81.95%           
=======================================
  Files         714      714           
  Lines       73434    73434           
  Branches     3616     3616           
=======================================
  Hits        60180    60180           
  Misses      12091    12091           
  Partials     1163     1163           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@QuantumMisaka
Copy link
Contributor

My simple test passed by using dataset in corresponding issue

@wanghan-iapcm wanghan-iapcm added this pull request to the merge queue Jan 27, 2026
Merged via the queue into deepmodeling:master with commit d5d5155 Jan 27, 2026
79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] dp eval-desc ValueError when deal with deepmd/npy/mixed format contain multiple frames

3 participants