fix: pass mixed_type to eval_descriptor in cli#5177
fix: pass mixed_type to eval_descriptor in cli#5177wanghan-iapcm merged 1 commit intodeepmodeling:masterfrom
Conversation
📝 WalkthroughWalkthroughThe change adds the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This pull request fixes a bug in the dp eval-desc command where the mixed_type parameter was not being passed to the eval_descriptor method, causing a ValueError when processing deepmd/npy/mixed format MultiSystems with multiple frames.
Changes:
- Added
mixed_type=mixed_typeparameter to thedp.eval_descriptor()call in the CLI entrypoint
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@QuantumMisaka could you test this PR? Thanks! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5177 +/- ##
=======================================
Coverage 81.95% 81.95%
=======================================
Files 714 714
Lines 73434 73434
Branches 3616 3616
=======================================
Hits 60180 60180
Misses 12091 12091
Partials 1163 1163 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
My simple test passed by using dataset in corresponding issue |
Fix #5176.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.