Skip to content

[pre-commit.ci] pre-commit autoupdate #1533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 7, 2024

Conversation

pre-commit-ci[bot]
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Apr 29, 2024

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.49%. Comparing base (f240e8b) to head (a8a8984).

Additional details and impacted files
@@           Coverage Diff           @@
##            devel    #1533   +/-   ##
=======================================
  Coverage   49.49%   49.49%           
=======================================
  Files          83       83           
  Lines       14816    14816           
=======================================
  Hits         7333     7333           
  Misses       7483     7483           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@njzjz njzjz self-assigned this May 1, 2024
@njzjz
Copy link
Member

njzjz commented May 1, 2024

 ======================================================================
FAIL: testEntry (tests.database.test_db_vasp.Test)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/dpgen/dpgen/tests/database/test_db_vasp.py", line 113, in testEntry
    self.assertEqual(
AssertionError: 'Automatic kpoint scheme\n0\nMonkhorst\n8 9 8\n' != 'Automatic kpoint scheme\n0\nMonkhorst\n8.0 9.0 8.0\n'
  Automatic kpoint scheme
  0
  Monkhorst
- 8 9 8
+ 8.0 9.0 8.0

@njzjz
Copy link
Member

njzjz commented May 6, 2024

ok... it may be a breaking change from pymatgen

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.4.1 → v0.4.3](astral-sh/ruff-pre-commit@v0.4.1...v0.4.3)
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 6ea3913 to 8998514 Compare May 6, 2024 21:29
@wanghan-iapcm wanghan-iapcm merged commit 59e0f70 into devel May 7, 2024
11 checks passed
@wanghan-iapcm wanghan-iapcm deleted the pre-commit-ci-update-config branch May 7, 2024 03:35
@njzjz njzjz mentioned this pull request May 7, 2024
njzjz added a commit that referenced this pull request May 7, 2024
Follow up #1533

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Refactor**
- Updated string formatting across various modules to use f-strings for
improved readability and consistency in error messages, log entries, and
data output.
- **Style**
- Enhanced string interpolation methods from older formatting styles to
modern f-string syntax across the application, ensuring uniformity and
clearer code presentation.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants