-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "fix(CI): remove CI
env var to fix the CI"
#1705
Conversation
This reverts commit 99b16e7.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #1705 +/- ##
=======================================
Coverage 49.51% 49.51%
=======================================
Files 83 83
Lines 14863 14863
=======================================
Hits 7359 7359
Misses 7504 7504 ☔ View full report in Codecov by Sentry. |
📝 WalkthroughWalkthroughThe pull request modifies the GitHub Actions workflow configuration file for testing a Python package. The change simplifies the test execution process by removing the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/test.yml (1)
24-24
: Consider adding explicit environment variable configurationInstead of relying on the default CI environment variable, consider explicitly setting required environment variables for test execution. This makes the test behavior more predictable and documented.
- run: coverage run --source=./dpgen -m unittest -v && coverage report + env: + TEST_ENV: ci + run: coverage run --source=./dpgen -m unittest -v && coverage report
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/test.yml
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: build (3.12)
- GitHub Check: build (3.9)
- GitHub Check: Analyze (python)
- GitHub Check: build (3.12)
🔇 Additional comments (1)
.github/workflows/test.yml (1)
24-24
: Verify the impact of CI environment variable on test executionThe removal of
unset CI
command might affect how tests behave in the CI environment. This change appears to be reverting PR #1704, but we should verify if this aligns with the discussion in pymatgen#4243.Let's verify the context and impact:
✅ Verification successful
CI environment variable removal appears safe
The codebase shows no direct usage of the CI environment variable in tests or configuration files. The removal of
unset CI
command should not impact test execution.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check for CI environment variable usage in tests and related discussions # Check for CI environment variable usage in test files echo "Checking for CI environment variable usage in tests..." rg -l "os\.environ\.get\(['\"]CI['\"]" || rg -l "os\.getenv\(['\"]CI['\"]" # Fetch the referenced issue discussion echo "Fetching related issue discussion..." gh issue view 4243 --repo pymatgen/pymatgenLength of output: 422
Script:
#!/bin/bash # Search for CI environment variable usage with broader patterns echo "Checking for CI environment variable usage (broader patterns)..." rg -l "CI['\"]?\s*[=:]|['\"]CI['\"]|environ.*CI|CI.*environ" # Look for test configuration files echo "Looking for test configuration files..." fd -e ini -e cfg -e conf -e toml -e yaml -e yml # Get context about PR #1704 echo "Getting PR #1704 information..." gh pr view 1704 || git log --grep="1704" --onelineLength of output: 835
Reverts #1704
See materialsproject/pymatgen#4243 (comment)
Summary by CodeRabbit