Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate SentencePiece package declaration #115

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yschungmr
Copy link

Description:
This PR addresses a redundancy in the requirements.txt file by removing the duplicate declaration of the SentencePiece package. Currently, the package is listed twice:

  • As sentencepiece (lowercase, no version specified)
  • As SentencePiece==0.1.96 (with specific version)

Changes made:

  • Removed the unversioned sentencepiece entry
  • Retained SentencePiece==0.1.96 for version consistency

Rationale:

  • Python packages are case-insensitive, making these entries effectively duplicate
  • Keeping the versioned dependency ensures reproducible builds
  • This change maintains project stability while cleaning up the dependency list

Testing:

  • Verified that the project builds successfully with the updated requirements.txt
  • Confirmed all dependent functionality remains intact

Please review and merge if appropriate.

fix: remove duplicate SentencePiece package from requirements.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant