Update README.md #42
Open
Update README.md #42
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hopefully save other people wasting time in frustration with an install dependancy.
rachfop
reviewed
Jan 28, 2025
| @@ -129,6 +129,7 @@ On the basis of `Python >= 3.8` environment, install the necessary dependencies | |||
| pip install -e . | |||
| ``` | |||
|
|
|||
| Please note: As at January 2025, 'torch' does support Python 3.13. Please use and earlier version of Python. | |||
There was a problem hiding this comment.
It is already mentioned here:
https://github.com/deepseek-ai/Janus/blob/main/janus/__init__.py#L25
I don't think it needs an update on the readme as this is a known issue with python 3.13.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully save other people wasting time in frustration with a torch dependency issue.