Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update modeling_vlm.py #69

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

AadiSharma49
Copy link

hello there i just
fix some things like:-

Config Class Refactoring: Reduced code duplication using a base configuration class.
Naming Conventions: Renamed vision_head to VisionHead for PEP8 compliance while maintaining backward compatibility.
Critical Bug Fix: Correctly passed parameters to gen_vision_model during initialization.
and other things also hope you you it
thanks!!

@AadiSharma49
Copy link
Author

AadiSharma49 commented Jan 28, 2025

hello there
Key Improvements
Config Class Refactoring: Reduced code duplication using a base configuration class.
Naming Conventions: Renamed vision_head to VisionHead for PEP8 compliance while maintaining backward compatibility.
Critical Bug Fix: Correctly passed parameters to gen_vision_model during initialization.
Validation Checks: Added an assertion to ensure mask compatibility.
Documentation: Enhanced docstrings and comments for clarity.
Type Hints: Added detailed type annotations for better code understanding and IDE support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant