Skip to content

feat: Add Multimodal RAG cookbook #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

sjrl
Copy link
Contributor

@sjrl sjrl commented Jul 15, 2025

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@sjrl sjrl marked this pull request as ready for review July 21, 2025 12:06
@sjrl sjrl requested a review from a team as a code owner July 21, 2025 12:06
@sjrl
Copy link
Contributor Author

sjrl commented Jul 21, 2025

@bilgeyucel this is ready for review!

@anakin87 anakin87 self-requested a review July 21, 2025 12:27
Copy link

review-notebook-app bot commented Jul 22, 2025

View / edit / reply to this conversation on ReviewNB

anakin87 commented on 2025-07-22T13:40:17Z
----------------------------------------------------------------

I would also explain that in the following Pipeline we are:

  • computing embeddings based on images for image files
  • converting PDF files to textual Documents and then computing embeddings based on the text

sjrl commented on 2025-07-23T11:27:00Z
----------------------------------------------------------------

sounds good!

Copy link

review-notebook-app bot commented Jul 22, 2025

View / edit / reply to this conversation on ReviewNB

anakin87 commented on 2025-07-22T13:40:17Z
----------------------------------------------------------------

Is it worth mentioning that other models (Jina Embeddings 4) might work better?


sjrl commented on 2025-07-23T11:27:23Z
----------------------------------------------------------------

Yeah I was thinking about that. I'll mention that here.

Copy link

review-notebook-app bot commented Jul 22, 2025

View / edit / reply to this conversation on ReviewNB

anakin87 commented on 2025-07-22T13:40:18Z
----------------------------------------------------------------

Something seems off in the first sentence.


Copy link
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I left some comments (while waiting on a review from @bilgeyucel)

We should also create a new entry in index.toml.

@anakin87 anakin87 requested a review from bilgeyucel July 22, 2025 13:42
Copy link
Contributor Author

sjrl commented Jul 23, 2025

sounds good!


View entire conversation on ReviewNB

Copy link
Contributor Author

sjrl commented Jul 23, 2025

Yeah I was thinking about that. I'll mention that here.


View entire conversation on ReviewNB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Image Indexing Example
2 participants