introduce allowImpersonateForRoles and denyImpersonateIntoRoles #1014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
thyseus
commented
Mar 1, 2018
thyseus
commented
| Q | A |
|---|---|
| Is bugfix? | no |
| New feature? | yes |
| Breaks BC? | no |
- Security related improvements about impersonating
Merged
|
LGTM |
|
Cool. Did not know LGTM yet. Looks great. But it says: ERROR: Could not detect a suitable build command for the source checkout. |
I meant "Looks good to me" :) and you? |
|
Hahahaha i thought you mean https://lgtm.com :) Thanks for reviewing. I already use this code in my live environments, if you have any idea or suggestion, let me know. |
|
I have good news. Let's wait for your word. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.