Skip to content
This repository was archived by the owner on Jul 23, 2021. It is now read-only.

Unrecognized property 'documentation' issue resolved by adding validation rules#171

Open
gordana16 wants to merge 1 commit intodeliveryhero:masterfrom
gordana16:add_validation_rules_doc_http_event
Open

Unrecognized property 'documentation' issue resolved by adding validation rules#171
gordana16 wants to merge 1 commit intodeliveryhero:masterfrom
gordana16:add_validation_rules_doc_http_event

Conversation

@gordana16
Copy link
Copy Markdown

The Serverless Framework has added http event validation since version 2.6.0 without including 'documentation' property. Plugin developers are encouraged to extend validation schema by adding validation rules for additional properties supported by plugin.

This PR resolves "Unrecognized property 'documentation'" triggered by serverless framework (since version 2.6.0) by adding JSON schema definition for 'documentation' property inside 'serverless-aws-plugin' constructor.

@dan-vidoni
Copy link
Copy Markdown

dan-vidoni commented Jan 5, 2021

@gordana16 awesome work! it's quite hard to review though because the linting rules were changed (I'm not a maintainer btw, just interested in the topic :p)

@ping2ravi
Copy link
Copy Markdown

Thanks @gordana16
This MR is important to me as well, waiting for maintainer to Merge it....

it seems to be in waiting state for 2 months now.... not sure if maintainer still looking after this repository..

@ydvsailendar
Copy link
Copy Markdown

Any updates on after how long will this be available?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants