Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated release action #59

Merged
merged 4 commits into from
Feb 17, 2025
Merged

Updated release action #59

merged 4 commits into from
Feb 17, 2025

Conversation

harishp8889
Copy link

Description

Updated release action to incorporate latest changes.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1490

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

@harishp8889 harishp8889 self-assigned this Feb 5, 2025
alikdell
alikdell reviewed Feb 17, 2025
View reviewed changes
.github/workflows/release.yaml
@@ -1,15 +1,23 @@
name: Release GoCSI
# Invocable as a reusable workflow
# Can be manually triggered
on: # yamllint disable-line rule:truthy
on: # yamllint disable-line rule:truthy
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No new warning, fix it

@alikdell alikdell merged commit 4139890 into main Feb 17, 2025
7 checks passed
@alikdell alikdell deleted the feature/release-updates branch February 17, 2025 23:15
@shaynafinocchiaro shaynafinocchiaro mentioned this pull request Feb 18, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alikdell alikdell alikdell left review comments

@donatwork donatwork donatwork approved these changes

@ChristianAtDell ChristianAtDell ChristianAtDell approved these changes

Assignees

@harishp8889 harishp8889

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@harishp8889 @donatwork @alikdell @ChristianAtDell