Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update metadata field builder #3149

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

Nordalf
Copy link
Contributor

@Nordalf Nordalf commented Jan 21, 2025

Description

Implements a new operation: UpdateFieldMetadataBuilder to upsert metadata on a field in a schema. The implementation checks for conflicts with protected metadata (e.g. from column mappings).

This only modifies metadata in a field. No schema evolution occurs.

Related Issue(s)

Stems from a conversation on Slack

Documentation

No documentation.

@github-actions github-actions bot added the binding/rust Issues for the Rust crate label Jan 21, 2025
Copy link

ACTION NEEDED

delta-rs follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

@Nordalf
Copy link
Contributor Author

Nordalf commented Jan 21, 2025

This builder is open for suggestions and is meant to be discussed. On Slack, @ion-elgreco and I wrote about whether the functionality was a part of column mapping But for now, this operation is able to modify the field metadata without schema drift/evolution.

Looking forward to get some review, have a debate, or getting roasted 🚀 😄

@Nordalf Nordalf changed the title Feat/update metadata field builder feat: update metadata field builder Jan 21, 2025
@rtyler
Copy link
Member

rtyler commented Jan 21, 2025

@Nordalf are you able to sign your commit(s)? git commit -s typically does it, but --signoff exists on a number of other commands. We use Developer Certificate of Origin as a way to ask developers to attest that they're the author of the commit and can rightfully license it MIT 😄

If you need help with it, holler my way in the channel 😃

@rtyler rtyler added the enhancement New feature or request label Jan 21, 2025
@rtyler rtyler added this to the v0.24 milestone Jan 21, 2025
@Nordalf
Copy link
Contributor Author

Nordalf commented Jan 21, 2025

@rtyler let me see what I can do to add the signoff for my previous commits. I will remember that for future commits 😄. If it does not work out as expected, I will reach out!

@Nordalf Nordalf force-pushed the feat/update-metadata-field-builder branch from 857e84d to bf82ff0 Compare January 21, 2025 18:59
@Nordalf Nordalf requested a review from fvaleye as a code owner January 21, 2025 18:59
@github-actions github-actions bot added the binding/python Issues for the Python package label Jan 21, 2025
@Nordalf
Copy link
Contributor Author

Nordalf commented Jan 21, 2025

To add DCO, it got a bit messy. I am willing to close and open a new PR to fix this - if necessary

@github-actions github-actions bot removed the binding/python Issues for the Python package label Jan 21, 2025
Implements a new UpdateFieldMetadataBuilder / operation to upsert metadata on a field in a schema. The implementation checks for conflicts with protected metadata (e.g. from column mappings). This is only a metadata change, and therefore, no schema evolution occurs.

Signed-off-by: Alexander Falk <[email protected]>
@rtyler rtyler force-pushed the feat/update-metadata-field-builder branch from d852211 to c359be8 Compare January 22, 2025 17:21
@rtyler rtyler enabled auto-merge January 22, 2025 17:21
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 0% with 99 lines in your changes missing coverage. Please review.

Project coverage is 71.74%. Comparing base (3bff47b) to head (c359be8).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...rates/core/src/operations/update_field_metadata.rs 0.00% 95 Missing ⚠️
crates/core/src/operations/mod.rs 0.00% 3 Missing ⚠️
crates/core/src/protocol/mod.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3149      +/-   ##
==========================================
- Coverage   71.90%   71.74%   -0.16%     
==========================================
  Files         137      138       +1     
  Lines       44263    44362      +99     
  Branches    44263    44362      +99     
==========================================
+ Hits        31826    31829       +3     
- Misses      10397    10497     +100     
+ Partials     2040     2036       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rtyler rtyler added this pull request to the merge queue Jan 22, 2025
Merged via the queue into delta-io:main with commit 523c6d7 Jan 22, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/rust Issues for the Rust crate enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants