-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update metadata field builder #3149
feat: update metadata field builder #3149
Conversation
ACTION NEEDED delta-rs follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
This builder is open for suggestions and is meant to be discussed. On Slack, @ion-elgreco and I wrote about whether the functionality was a part of column mapping But for now, this operation is able to modify the field metadata without schema drift/evolution. Looking forward to get some review, have a debate, or getting roasted 🚀 😄 |
@Nordalf are you able to sign your commit(s)? If you need help with it, holler my way in the channel 😃 |
@rtyler let me see what I can do to add the signoff for my previous commits. I will remember that for future commits 😄. If it does not work out as expected, I will reach out! |
857e84d
to
bf82ff0
Compare
To add DCO, it got a bit messy. I am willing to close and open a new PR to fix this - if necessary |
Implements a new UpdateFieldMetadataBuilder / operation to upsert metadata on a field in a schema. The implementation checks for conflicts with protected metadata (e.g. from column mappings). This is only a metadata change, and therefore, no schema evolution occurs. Signed-off-by: Alexander Falk <[email protected]>
d852211
to
c359be8
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3149 +/- ##
==========================================
- Coverage 71.90% 71.74% -0.16%
==========================================
Files 137 138 +1
Lines 44263 44362 +99
Branches 44263 44362 +99
==========================================
+ Hits 31826 31829 +3
- Misses 10397 10497 +100
+ Partials 2040 2036 -4 ☔ View full report in Codecov by Sentry. |
Description
Implements a new operation:
UpdateFieldMetadataBuilder
toupsert
metadata on a field in a schema. The implementation checks for conflicts with protected metadata (e.g. fromcolumn mappings
).This only modifies metadata in a field. No schema evolution occurs.
Related Issue(s)
Stems from a conversation on Slack
Documentation
No documentation.