fix: remove the vendoring of SSL with rdkafka #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't have a good reason for kafka-delta-ingest to do this, I'm confident it was previously done for wacky build problems. This change also removes Cargo.lock which I don't believe is worth tracking in our tree Fixes delta-io#176
mightyshazam
approved these changes
Jul 9, 2024
| @@ -20,7 +20,7 @@ jmespatch = { version = "0.3", features = ["sync"] } | |||
| lazy_static = "1" | |||
| log = "0" | |||
| maplit = "1" | |||
| rdkafka = { version = "0.28", features = ["ssl-vendored"] } | |||
| rdkafka = { version = "0.28", features = ["ssl"] } | |||
There was a problem hiding this comment.
It might be nice to have this running behind a feature flag for those running on scratch images without openssl.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't have a good reason for kafka-delta-ingest to do this, I'm confident it was previously done for wacky build problems.
This change also removes Cargo.lock which I don't believe is worth tracking in our tree
Fixes #176