Rewrite it in python #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
missytake
force-pushed
the
python-rewrite
branch
from
74e883b to
60e35ca
Compare
missytake
force-pushed
the
python-rewrite
branch
2 times, most recently
from
36012f6 to
5be9c22
Compare
missytake
force-pushed
the
python-rewrite
branch
from
5be9c22 to
d5f9429
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on chatmail/core#7219, which will be in core 2.16.0. Once core 2.16.0 is available, CI should work.
Since chatmail/core#7221, this will also fix #9.
I didn't really figure out a way to test this yet - the functions can not really be isolated to test by themselves, I think we need integration tests where actual accounts talk to each other. But how to tell an acfactory bot to listen to certain hooks? :/
Maybe https://github.com/deltachat-bot/deltawoot/blob/main/tests/test_recv.py#L16 can serve as an inspiration