Conversation
There was a problem hiding this comment.
Pull request overview
Adds Android string resources needed to surface a new “Calls” notification setting (referenced by deltachat-desktop follow-up work).
Changes:
- Added title string for the “Calls” notification setting.
- Added explanatory/summary string for the “Calls” notification setting.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <string name="prev_calls">Calls</string> | ||
| <!-- Details about what the "Calls" notification settings does --> | ||
| <string name="prev_calls_explain">Show call screen on incoming calls</string> |
There was a problem hiding this comment.
The new string resource names prev_calls / prev_calls_explain don’t match the established pref_... naming used throughout the preferences section (e.g., pref_notifications, pref_mention_notifications_explain). This looks like a typo and will likely cause future references (or existing conventions) to miss these resources. Rename them to use the pref_... prefix consistently (and ensure the chosen name matches the preference key that will reference it).
| <string name="prev_calls">Calls</string> | |
| <!-- Details about what the "Calls" notification settings does --> | |
| <string name="prev_calls_explain">Show call screen on incoming calls</string> | |
| <string name="pref_calls">Calls</string> | |
| <!-- Details about what the "Calls" notification settings does --> | |
| <string name="pref_calls_explain">Show call screen on incoming calls</string> |
| <string name="pref_mention_notifications_explain">In muted groups, notify messages directed to you, like replies or reactions</string> | ||
| <!-- Title for the "Calls" notification setting. This is a plural noun, not a verb. --> | ||
| <string name="prev_calls">Calls</string> | ||
| <!-- Details about what the "Calls" notification settings does --> |
There was a problem hiding this comment.
Grammar in the translator comment is off: it says "notification settings does" (plural + singular verb). Consider rewording to something like "Details about what the "Calls" notification setting does" to avoid confusion for translators.
| <!-- Details about what the "Calls" notification settings does --> | |
| <!-- Details about what the "Calls" notification setting does --> |
|
To test the changes in this pull request, install this apk: |
needed by deltachat/deltachat-desktop#6079
discussed at deltachat/deltachat-desktop#6044 (comment)