ENH: Require NumPy greater or equal to 1.26.0#60
Merged
demianw merged 1 commit intodemianw:masterfrom May 28, 2025
Merged
Conversation
This was referenced Dec 10, 2024
jhlegarreta
force-pushed
the
RequirePython312NumpyCompatVersion
branch
3 times, most recently
from
8eacfb8 to
4cd6aee
Compare
Contributor
Author
|
I will rebase on |
jhlegarreta
force-pushed
the
RequirePython312NumpyCompatVersion
branch
3 times, most recently
from
272bef5 to
c3a01ea
Compare
Require `NumPy` greater or equal to 1.26.0: 1.26.0 is the first release that supported Python 3.12 and supports versions 3.9-3.12. No longer restrict `NumPy` versions to the 1.x series. Documentation: https://github.com/numpy/numpy/releases/tag/v1.26.0 Require `NiBabel` greater or equal to 4.0.0: the old `trackvis` API existing in previous versions was removed starting from version 4.0.0. `tract_querier` reliance on the old `trackvis` API was removed in commit 813b570. The 4.0.0 version release notes can be read in: https://github.com/nipy/nibabel/releases/tag/4.0.0 No longer restrict VTK versions to the 8.x series. Add Python 3.12 and 3.13 to the GHA package testing matrix. For Python 3.13 exclude the `minimal` dependency configuration as some are not compatible with it.
jhlegarreta
force-pushed
the
RequirePython312NumpyCompatVersion
branch
from
c3a01ea to
e72d4e3
Compare
Contributor
Author
|
Gentle reminder: this is ready to be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Require
NumPygreater or equal to 1.26.0: 1.26.0 is the first release that supported Python 3.12 and supports versions 3.9-3.12.No longer restrict
NumPyversions to the 1.x series.Documentation:
https://github.com/numpy/numpy/releases/tag/v1.26.0
Require
NiBabelgreater or equal to 4.0.0: the oldtrackvisAPI existing in previous versions was removed starting from version 4.0.0.tract_querierreliance on the oldtrackvisAPI was removed in commit813b570.
The 4.0.0 version release notes can be read in:
https://github.com/nipy/nibabel/releases/tag/4.0.0
No longer restrict VTK versions to the 8.x series.
Add Python 3.12 and 3.13 to the GHA package testing matrix. For Python 3.13 exclude the
minimaldependency configuration as some are not compatible with it.