Skip to content

Commit

Permalink
[BOLT] Avoid repeated map lookups (NFC) (llvm#112118)
Browse files Browse the repository at this point in the history
  • Loading branch information
kazutakahirata authored Oct 13, 2024
1 parent 464a7ee commit 7928e14
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions bolt/lib/Core/BinaryFunction.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3684,9 +3684,8 @@ BinaryFunction::BasicBlockListType BinaryFunction::dfs() const {
BinaryBasicBlock *BB = Stack.top();
Stack.pop();

if (Visited.find(BB) != Visited.end())
if (!Visited.insert(BB).second)
continue;
Visited.insert(BB);
DFS.push_back(BB);

for (BinaryBasicBlock *SuccBB : BB->landing_pads()) {
Expand Down Expand Up @@ -3879,11 +3878,8 @@ void BinaryFunction::disambiguateJumpTables(
JumpTable *JT = getJumpTable(Inst);
if (!JT)
continue;
auto Iter = JumpTables.find(JT);
if (Iter == JumpTables.end()) {
JumpTables.insert(JT);
if (JumpTables.insert(JT).second)
continue;
}
// This instruction is an indirect jump using a jump table, but it is
// using the same jump table of another jump. Try all our tricks to
// extract the jump table symbol and make it point to a new, duplicated JT
Expand Down

0 comments on commit 7928e14

Please sign in to comment.