Skip to content

Commit

Permalink
[ci] Don't add check-all target when pstl project is enabled (llvm#11…
Browse files Browse the repository at this point in the history
…1803)

Fixes llvm#110265

Adding check-all causes us to run some tests twice if a project specific
target like check-clang is also added.

check-pstl is an alternative but as far as I can tell, check-all does
not include this so we have not been running the tests in CI anyway.

When I tried to run check-pstl locally I got a lot of compiler errors
but have not found any instructions on how to setup a correct build
environment. Even if such instructions exist, it's probably more than we
want to do in CI.

According to Louis Dionne, the project is probably not active. So if
it's ever revived it'll be up to the new contributors to enable testing.
  • Loading branch information
DavidSpickett authored Oct 10, 2024
1 parent 159d694 commit 9014920
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion .ci/generate-buildkite-pipeline-premerge
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,9 @@ function keep-modified-projects() {
}

function check-targets() {
# Do not use "check-all" here because if there is "check-all" plus a
# project specific target like "check-clang", that project's tests
# will be run twice.
projects=${@}
for project in ${projects}; do
case ${project} in
Expand All @@ -216,7 +219,7 @@ function check-targets() {
echo "check-lldb"
;;
pstl)
echo "check-all"
# Currently we do not run pstl tests in CI.
;;
libclc)
# Currently there is no testing for libclc.
Expand Down

0 comments on commit 9014920

Please sign in to comment.