Skip to content

Conversation

MLainer1
Copy link
Contributor

@MLainer1 MLainer1 commented Sep 8, 2025

…ypted types

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

Convert the parameters to type 9 - encrypted
image

Must have

  • Tests
  • Documentation

Copy link

github-actions bot commented Sep 8, 2025

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/MicrosoftDefenderAdvancedThreatProtection/Integrations/MicrosoftDefenderAdvancedThreatProtection
   MicrosoftDefenderAdvancedThreatProtection.py212984260%229, 261, 396, 632, 697, 699, 704, 854, 857, 927, 1008, 1010, 1012, 1106, 1109–1118, 1139, 1158, 1173, 1182, 1206, 1212, 1295, 1299, 1306, 1309, 1312, 1321–1324, 1341–1344, 1360–1362, 1394–1396, 1407–1408, 1419–1420, 1432–1433, 1450–1452, 1460–1462, 1464, 1474–1484, 1492–1493, 1506–1510, 1528–1529, 1539, 1550–1551, 1562–1563, 1574–1575, 1586–1587, 1602–1603, 1617–1621, 1633–1635, 1648–1649, 1667–1669, 1685–1687, 1704–1706, 1717–1718, 1729–1730, 1740–1741, 1754–1755, 1758, 1769–1770, 1781–1782, 1793–1794, 1805–1806, 1817–1818, 1829–1830, 1841–1842, 1853–1854, 1865–1866, 1879–1881, 1893–1894, 1918, 1923–1932, 1943–1944, 1946–1948, 1964–1965, 1971–1972, 1983–1986, 1988–1989, 1992–1994, 1998–1999, 2002, 2004–2007, 2018, 2026–2027, 2061, 2069, 2078, 2085, 2091, 2098, 2114–2118, 2122–2123, 2136–2137, 2142–2143, 2146, 2149–2150, 2153, 2156–2160, 2163–2165, 2177–2182, 2194–2199, 2208–2209, 2218–2219, 2228–2229, 2238–2239, 2247–2250, 2252, 2264–2265, 2274–2275, 2283–2287, 2299–2300, 2308–2312, 2320, 2322, 2375, 2387, 2389–2390, 2412–2424, 2426–2429, 2432–2433, 2442–2453, 2455–2458, 2464–2465, 2482, 2493, 2503–2509, 2511–2520, 2523–2525, 2527, 2535–2536, 2538–2540, 2542–2544, 2688, 2698–2702, 2704–2713, 2715, 2718–2719, 2815–2817, 2973–2975, 2991, 3003–3008, 3013–3015, 3017–3018, 3021, 3046–3051, 3053–3059, 3064–3065, 3070–3087, 3118, 3131–3133, 3137, 3143, 3153, 3165, 3175, 3177–3179, 3188–3192, 3194–3195, 3197–3201, 3203–3206, 3231, 3251, 3310–3326, 3328–3332, 3336–3342, 3345–3347, 3351–3354, 3356, 3362, 3390, 3398–3399, 3402–3403, 3406–3407, 3412, 3591–3598, 3664–3667, 3669–3671, 3680, 3686, 3916, 3928–3934, 3943–3949, 3958, 3963, 3999, 4011–4017, 4050–4055, 4077, 4087–4090, 4093–4095, 4104, 4115–4122, 4139, 4164–4165, 4175–4176, 4180, 4242, 4244–4245, 4247, 4262–4266, 4268–4270, 4272–4276, 4278–4280, 4291, 4293–4294, 4296–4298, 4314–4316, 4329–4330, 4332, 4335, 4337, 4350–4357, 4359, 4377–4380, 4382, 4407–4422, 4433–4434, 4452, 4464–4468, 4485–4488, 4505, 4525–4529, 4546–4549, 4562–4567, 4569, 4572–4578, 4591–4593, 4606–4608, 4621–4631, 4633, 4646–4649, 4655, 4663, 4676–4681, 4683–4687, 4690, 4719–4721, 4729–4734, 4740, 4749, 4751, 5083–5097, 5101–5105, 5107, 5238, 5297, 5405, 5425, 5518, 5528–5532, 5534–5544, 5546–5547, 5550–5551, 5592, 5601–5602, 5606–5612, 5614–5628, 5630, 5633–5637, 5646, 5650, 5689–5693, 5704, 5706, 5708–5712, 5718, 5729–5730, 5736, 5772–5776, 5778, 5895, 5898–5901, 5921–5924, 5927–5931, 5933, 5942–5943, 5945, 5949–5951, 5953–5958, 5960, 5967, 6000–6001, 6003–6009, 6023, 6053, 6056–6057, 6060–6061, 6069, 6081, 6111, 6120
TOTAL212984260% 

Tests Skipped Failures Errors Time
179 0 💤 0 ❌ 0 🔥 7.238s ⏱️

@MLainer1 MLainer1 added the ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines label Sep 8, 2025
@MLainer1 MLainer1 marked this pull request as ready for review September 10, 2025 07:54
@MLainer1 MLainer1 requested a review from Shellyber September 10, 2025 07:54
Copy link
Contributor

@Shellyber Shellyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just fix the RN please :)

@content-bot
Copy link
Collaborator

Validate summary
The following errors were thrown as a part of this pr: .
If the AG100 validation in the pre-commit GitHub Action fails, the pull request cannot be force-merged.

Verdict: PR can be force merged from validate perspective? ✅

@MLainer1 MLainer1 merged commit d885347 into master Sep 14, 2025
19 checks passed
@MLainer1 MLainer1 deleted the MDE_change_parameter_types branch September 14, 2025 10:18
scohenkadosh pushed a commit that referenced this pull request Sep 15, 2025
#41204)

* fix: update Microsoft Defender ATP integration parameters to use encrypted types

* fix: update auth parameter types to encrypted and fix password retrieval in Microsoft Defender ATP

* fix: change display to displaypassword for hidden auth fields in Microsoft Defender ATP integration

* fix: replace deprecated _pytest.python_api.raises with pytest.raises

* Creating new parameters to avoid BC
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Sep 17, 2025
demisto#41204)

* fix: update Microsoft Defender ATP integration parameters to use encrypted types

* fix: update auth parameter types to encrypted and fix password retrieval in Microsoft Defender ATP

* fix: change display to displaypassword for hidden auth fields in Microsoft Defender ATP integration

* fix: replace deprecated _pytest.python_api.raises with pytest.raises

* Creating new parameters to avoid BC
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-approved ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants