Skip to content

Conversation

almog2296
Copy link
Contributor

@almog2296 almog2296 commented Sep 8, 2025

Fixed a bug where get-endpoint-data searched for users containing \ with the name argument instead of using the username argument.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-14680

Description

When running !get-user-data username=test\user get-user-data called !ad-get-user name=user instead of !ad-get-user username.

Copy link

github-actions bot commented Sep 8, 2025

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/AggregatedScripts/Scripts/GetUserData
   GetUserData.py4146584%576, 674–676, 702, 717–719, 726–728, 734, 737–738, 746–747, 810–811, 826–827, 842–844, 849–852, 867–868, 883–884, 899–900, 919–920, 941–942, 957–959, 964–967, 982–983, 998–999, 1014–1015, 1030–1031, 1052–1053, 1084–1085, 1100–1101, 1116–1117, 1120, 1138–1139, 1157–1158
TOTAL4146584% 

Tests Skipped Failures Errors Time
81 0 💤 0 ❌ 0 🔥 2.929s ⏱️

@almog2296 almog2296 added the ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines label Sep 9, 2025
@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • AggregatedScripts pack version was bumped to 1.1.12.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@richardbluestone
Copy link
Contributor

Doc review done

Copy link
Contributor

@Shellyber Shellyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test

@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • AggregatedScripts pack version was bumped to 1.1.14.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@almog2296 almog2296 requested a review from Shellyber September 15, 2025 06:40
Copy link
Contributor

@Shellyber Shellyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great just see my comment

Copy link
Contributor

@Shellyber Shellyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great

@content-bot
Copy link
Collaborator

Validate summary
The following errors were thrown as a part of this pr: .
If the AG100 validation in the pre-commit GitHub Action fails, the pull request cannot be force-merged.

Verdict: PR can be force merged from validate perspective? ✅

@almog2296 almog2296 merged commit f32b3d5 into master Sep 15, 2025
19 checks passed
@almog2296 almog2296 deleted the get-user-data-CIAC-14680 branch September 15, 2025 11:35
scohenkadosh pushed a commit that referenced this pull request Sep 15, 2025
* Commit

* Commit

* Chnaged argname under ad-get-user

* Update release notes

* Merged From Master

* Bump pack from version AggregatedScripts to 1.1.12.

* Update Packs/AggregatedScripts/ReleaseNotes/1_1_12.md

Co-authored-by: Shelly Tzohar <[email protected]>

* added tests

* Bump pack from version AggregatedScripts to 1.1.14.

* update relesae notes

---------

Co-authored-by: Content Bot <[email protected]>
Co-authored-by: Shelly Tzohar <[email protected]>
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Sep 17, 2025
* Commit

* Commit

* Chnaged argname under ad-get-user

* Update release notes

* Merged From Master

* Bump pack from version AggregatedScripts to 1.1.12.

* Update Packs/AggregatedScripts/ReleaseNotes/1_1_12.md

Co-authored-by: Shelly Tzohar <[email protected]>

* added tests

* Bump pack from version AggregatedScripts to 1.1.14.

* update relesae notes

---------

Co-authored-by: Content Bot <[email protected]>
Co-authored-by: Shelly Tzohar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-approved ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants