Skip to content

Progress still depends on variable tj #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Progress still depends on variable tj #13

wants to merge 1 commit into from

Conversation

Apfelholz
Copy link
Collaborator

fix #12

@Apfelholz Apfelholz added the bug Something isn't working label Nov 8, 2024
@Apfelholz Apfelholz requested a review from dennisklein November 8, 2024 09:53
@Apfelholz Apfelholz self-assigned this Nov 8, 2024
dennisklein
dennisklein requested changes Nov 8, 2024
View reviewed changes
Copy link
Owner

@dennisklein dennisklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls rebase your commit onto main

@Apfelholz Apfelholz force-pushed the progress-still-depends-on-variable-tj branch from 6163c02 to 01930e1 Compare November 8, 2024 10:19
@Apfelholz Apfelholz requested a review from dennisklein November 8, 2024 10:22
dennisklein
dennisklein requested changes Nov 8, 2024
View reviewed changes
Copy link
Owner

@dennisklein dennisklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now content-wise, please fix the formatting and rebase onto the main branch of this repo.

@Apfelholz Apfelholz force-pushed the progress-still-depends-on-variable-tj branch 2 times, most recently from 7a3b7cc to 2a657fa Compare November 8, 2024 11:08
@Apfelholz Apfelholz requested a review from dennisklein November 8, 2024 11:08
dennisklein
dennisklein requested changes Nov 8, 2024
View reviewed changes
@Apfelholz Apfelholz force-pushed the progress-still-depends-on-variable-tj branch 2 times, most recently from 0023ce1 to eafdc31 Compare November 8, 2024 12:46
@Apfelholz Apfelholz requested a review from dennisklein November 8, 2024 12:47
Apfelholz
Apfelholz commented Nov 8, 2024
View reviewed changes
ptop.py Outdated
print(f"Error reading the file '{args.logfile}': {e}")
except ZeroDivisionError:
print("Error: Total jobs parameter must be a positive integer.")
print("Error: Total jobs parameter must be a positive integer.")
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont now way taht is thare, it schoden't be

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check https://github.com/dennisklein/exercise_gnu_parallel_top/actions/runs/11742381109/job/32712985482?pr=13#step:6:18 -> "\ No newline at end of file"

@Apfelholz Apfelholz force-pushed the progress-still-depends-on-variable-tj branch from eafdc31 to 9d54dd4 Compare November 8, 2024 13:28
@Apfelholz Apfelholz force-pushed the progress-still-depends-on-variable-tj branch from 9d54dd4 to a87bb0c Compare November 8, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dennisklein dennisklein Awaiting requested review from dennisklein

Assignees

@Apfelholz Apfelholz

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

progress() still depends on variable tj
2 participants
@Apfelholz @dennisklein