fix type declarations for getContext on raw desktop backend#36182
Draft
Giesch wants to merge 3 commits into
Draft
fix type declarations for getContext on raw desktop backend#36182Giesch wants to merge 3 commits into
Giesch wants to merge 3 commits into
Conversation
…dowSurface.getContext
Mirrors the overload set already declared on OffscreenCanvas.getContext,
so getContext("webgpu") narrows to GPUCanvasContext | null instead of
OffscreenRenderingContext | null. The runtime (ext/canvas/byow.rs)
supports exactly the bitmap and webgpu contexts.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…enderingContext Without a construct signature on the constructor objects, `x instanceof GPUCanvasContext` fails with TS2359 even though it works at runtime. Matches the @webgpu/types and lib.dom convention. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Giesch
force-pushed
the
giesch/raw-desktop-type-def-fix
branch
from
July 21, 2026 11:56
cd9632b to
a3263fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the declared types on getContext to match the way they're used in the documentation (returning a
GPUCanvasContextforcontextId: "webgpu").I used Claude Code while working on this PR