fix(core): validate op buffer backing stores - #36260
Open
nathanwhit wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates op2 buffer conversion so generated ops do not borrow slices from backing stores whose address or concurrency properties can change.
Read-only shared and resizable inputs are snapshotted before dispatch, preserving ordinary input behavior. Mutable, retained, and raw-pointer mappings reject those stores because copying would change their mutation or ownership contract. Detach-mode buffers keep their existing ownership-transfer path.
The fast and slow dispatch paths now apply the same rules. Regression coverage exercises shared and resizable typed arrays, ArrayBuffers, DataViews, retained buffers, raw pointers, copy-mode inputs, and Node isUtf8/isAscii compatibility.
Tests: