Skip to content

feat(dcore): Allow to load snapshot from file #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(dcore): Allow to load snapshot from file #607

wants to merge 2 commits into from

Conversation

@bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Feb 26, 2024

No description provided.

mmastrac
mmastrac reviewed Feb 26, 2024
View reviewed changes
Copy link
Contributor

@mmastrac mmastrac left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before we go too far on this I think we should try to merge it into checkin. I've already done a bunch of work to snapshot in there and it's better if we can avoid having a second bit of testing infra to maintain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mmastrac mmastrac mmastrac left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bartlomieju @mmastrac