Skip to content

feat(streams): new ExactReader #5492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions streams/deno.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
"./concat-readable-streams": "./concat_readable_streams.ts",
"./delimiter-stream": "./delimiter_stream.ts",
"./early-zip-readable-streams": "./early_zip_readable_streams.ts",
"./exact-reader": "./exact_reader.ts",
"./limited-bytes-transform-stream": "./limited_bytes_transform_stream.ts",
"./limited-transform-stream": "./limited_transform_stream.ts",
"./merge-readable-streams": "./merge_readable_streams.ts",
Expand Down
89 changes: 89 additions & 0 deletions streams/exact_reader.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,89 @@
// Copyright 2018-2024 the Deno authors. All rights reserved. MIT license.
// This module is browser compatible.
/**
* Converts a ReadableStream<Uint8Array> into a BYOB Reader that guarantees the
* buffer will be full, with the exception of the last value.
*
* @example Basic Usage
* ```ts
* import { ExactReader } from "@std/streams/exact-reader";
* import { assertEquals } from "@std/assert";
*
* const reader = new ExactReader((await Deno.open("./deno.json")).readable);
*
* const values = await Array.fromAsync(async function* () {
* while (true) {
* const { done, value } = await reader.read(new Uint8Array(1024));
* if (done) {
* break
* }
* yield value
* }
* }());
*
* values.slice(0, -1).forEach(value => assertEquals(value.length, 1024));
* ```
*/
export class ExactReader extends ReadableStreamBYOBReader {
/**
* Constructs a new instance.
*
* @param readable The ReadableStream<Uint8Array> to be consumed.
*/
constructor(readable: ReadableStream<Uint8Array>) {
const reader = readable.getReader();
let offset = 0;
let leftover: Uint8Array | undefined;
super(
new ReadableStream({
type: "bytes",
async pull(controller) {
if (!controller.byobRequest?.view) {
return;
}

Check warning on line 43 in streams/exact_reader.ts

View check run for this annotation

Codecov / codecov/patch

streams/exact_reader.ts#L42-L43

Added lines #L42 - L43 were not covered by tests

const buffer = new Uint8Array(controller.byobRequest.view.buffer);
if (leftover) {
if (leftover.length > buffer.length) {
buffer.set(leftover.slice(0, buffer.length));
leftover = leftover.slice(buffer.length);
return controller.byobRequest.respond(buffer.length);
}
buffer.set(leftover);
offset = leftover.length;
leftover = undefined;
}

while (true) {
const { done, value } = await reader.read();
if (done) {
if (offset) {
controller.byobRequest.respond(offset);
controller.close();
} else {
controller.close();
controller.byobRequest.respond(0);
}

Check warning on line 66 in streams/exact_reader.ts

View check run for this annotation

Codecov / codecov/patch

streams/exact_reader.ts#L64-L66

Added lines #L64 - L66 were not covered by tests
return;
}

const spaceAvailable = buffer.length - offset;
if (value.length > spaceAvailable) {
buffer.set(value.slice(0, spaceAvailable), offset);
leftover = value.slice(spaceAvailable);
controller.byobRequest.respond(buffer.length);
return;
}
buffer.set(value, offset);
offset += value.length;
if (buffer.length === offset) {
offset = 0;
controller.byobRequest.respond(buffer.length);
return;
}
}
},
}),
);
}
}
27 changes: 27 additions & 0 deletions streams/exact_reader_test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
// Copyright 2018-2024 the Deno authors. All rights reserved. MIT license.
import { assertEquals } from "../assert/equals.ts";
import { ExactReader } from "./exact_reader.ts";

Deno.test("ExactReader test", async () => {
const readable = ReadableStream.from(async function* () {
for (let i = 0; i < 1024; ++i) {
yield new Uint8Array(Math.floor(Math.random() * 1024));
}
}());

const reader = new ExactReader(readable);
const read = Math.ceil(Math.random() * 2048);
const sizes: number[] = [];
while (true) {
const { done, value } = await reader.read(new Uint8Array(read));
if (done) {
break;
}
sizes.push(value.length);
}

sizes.pop(); // Last value isn't guaranteed to be size `read`
for (const size of sizes) {
assertEquals(size, read);
}
});
1 change: 1 addition & 0 deletions streams/mod.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ export * from "./byte_slice_stream.ts";
export * from "./concat_readable_streams.ts";
export * from "./delimiter_stream.ts";
export * from "./early_zip_readable_streams.ts";
export * from "./exact_reader.ts";
export * from "./limited_bytes_transform_stream.ts";
export * from "./limited_transform_stream.ts";
export * from "./merge_readable_streams.ts";
Expand Down