Skip to content

Comments

BREAKING(cli/unstable): make ProgressBar writable optional#6409

Merged
kt3k merged 12 commits intodenoland:mainfrom
timreichen:cli-ProgressBar-make-writable-an-option
May 20, 2025
Merged

BREAKING(cli/unstable): make ProgressBar writable optional#6409
kt3k merged 12 commits intodenoland:mainfrom
timreichen:cli-ProgressBar-make-writable-an-option

Conversation

@timreichen
Copy link
Contributor

@timreichen timreichen commented Feb 15, 2025

This PR removes the ProgressBar writable argument and adds it as an optional property in options with Deno.stderr.writable as the default.

@timreichen timreichen requested a review from kt3k as a code owner February 15, 2025 11:34
@github-actions github-actions bot added the cli label Feb 15, 2025
@codecov
Copy link

codecov bot commented Feb 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.70%. Comparing base (49512f7) to head (5da8739).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6409      +/-   ##
==========================================
+ Coverage   94.69%   94.70%   +0.01%     
==========================================
  Files         562      562              
  Lines       46648    46646       -2     
  Branches     6569     6569              
==========================================
+ Hits        44172    44175       +3     
+ Misses       2432     2428       -4     
+ Partials       44       43       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kt3k kt3k changed the title feat(cli/unstable): make ProgressBar writable optional BREAKING(cli/unstable): make ProgressBar writable optional Feb 19, 2025
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k kt3k merged commit ba0fc29 into denoland:main May 20, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants