BREAKING(cli/unstable): make ProgressBar writable optional#6409
Merged
kt3k merged 12 commits intodenoland:mainfrom May 20, 2025
Merged
BREAKING(cli/unstable): make ProgressBar writable optional#6409kt3k merged 12 commits intodenoland:mainfrom
ProgressBar writable optional#6409kt3k merged 12 commits intodenoland:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6409 +/- ##
==========================================
+ Coverage 94.69% 94.70% +0.01%
==========================================
Files 562 562
Lines 46648 46646 -2
Branches 6569 6569
==========================================
+ Hits 44172 44175 +3
+ Misses 2432 2428 -4
+ Partials 44 43 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ProgressBar writable optionalProgressBar writable optional
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the
ProgressBarwritableargument and adds it as an optional property inoptionswithDeno.stderr.writableas the default.