feat(collections): option to merge undefined in deepMerge
#6522
+166
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6522 +/- ##
=======================================
Coverage 95.21% 95.22%
=======================================
Files 577 577
Lines 43381 43385 +4
Branches 6487 6489 +2
=======================================
+ Hits 41307 41312 +5
+ Misses 2034 2033 -1
Partials 40 40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ry
reviewed
Apr 9, 2025
collections/deep_merge.ts
Outdated
| * | ||
| * @default {"replace"} | ||
| */ | ||
| undefined?: "replace" | "ignore"; |
There was a problem hiding this comment.
strange that the key is a keyword undefined
There was a problem hiding this comment.
That's true. Maybe undefineds would be better?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #4752
Default is
"replace", which is the existing behavior.