-
Notifications
You must be signed in to change notification settings - Fork 645
chore: add no-external-code
rule to Deno Style Guide lint plugin
#6562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6562 +/- ##
==========================================
- Coverage 95.21% 94.57% -0.65%
==========================================
Files 577 579 +2
Lines 43381 43724 +343
Branches 6487 6492 +5
==========================================
+ Hits 41307 41351 +44
- Misses 2034 2332 +298
- Partials 40 41 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
if (context.filename.includes("_tools")) { | ||
// Tools are allowed to use external code | ||
return {}; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used ignore lint directives instead of plugin logic so that this plugin can be used for other codebases, as per the original intention of #6551. Either way, we can address this if that ends up happening.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this rule specific to std? I guess this rule only makes sense as private rule here
Towards #6551