Skip to content

chore: add no-external-code rule to Deno Style Guide lint plugin #6562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 15, 2025

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Apr 9, 2025

Towards #6551

Copy link

codecov bot commented Apr 9, 2025

Codecov Report

Attention: Patch coverage is 86.20690% with 4 lines in your changes missing coverage. Please review.

Project coverage is 94.57%. Comparing base (b5a5fe4) to head (bc6a89c).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
_tools/lint_plugin.ts 86.20% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6562      +/-   ##
==========================================
- Coverage   95.21%   94.57%   -0.65%     
==========================================
  Files         577      579       +2     
  Lines       43381    43724     +343     
  Branches     6487     6492       +5     
==========================================
+ Hits        41307    41351      +44     
- Misses       2034     2332     +298     
- Partials       40       41       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@iuioiua iuioiua marked this pull request as ready for review April 10, 2025 07:59
@iuioiua iuioiua requested a review from kt3k as a code owner April 10, 2025 07:59
@github-actions github-actions bot removed the html label Apr 15, 2025
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kt3k kt3k merged commit 40da1fb into denoland:main Apr 15, 2025
18 checks passed
@iuioiua iuioiua deleted the no-external-code branch April 15, 2025 08:00
Comment on lines +62 to +65
if (context.filename.includes("_tools")) {
// Tools are allowed to use external code
return {};
}
Copy link
Contributor Author

@iuioiua iuioiua Apr 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used ignore lint directives instead of plugin logic so that this plugin can be used for other codebases, as per the original intention of #6551. Either way, we can address this if that ends up happening.

Copy link
Member

@kt3k kt3k Apr 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this rule specific to std? I guess this rule only makes sense as private rule here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants