-
Notifications
You must be signed in to change notification settings - Fork 654
refactor(cli/unstable): print initial ProgressBar
#6676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6676 +/- ##
==========================================
- Coverage 94.70% 94.70% -0.01%
==========================================
Files 563 563
Lines 46681 46689 +8
Branches 6571 6575 +4
==========================================
+ Hits 44209 44216 +7
- Misses 2430 2431 +1
Partials 42 42 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I'm in favor of adding the initial |
There are two scenarios:
|
Then how about only printing when
There are still some delay between the last value/max assignment and printing of them (and the last printing can be skipped if we stop in the middle of delay). If we print at |
Ok that makes sense, with #6664 (once the issues are solved) the print function is will check whether there is an update and return early if not. I'll update this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR adds a
print()
call when the progress bar is initialized (setInterval()
only starts printing after the delay) and removes theprint()
call when it is stopped.