Skip to content

Commit

Permalink
Replace separate repo/path with single URI in VCR config for ARP allo…
Browse files Browse the repository at this point in the history
…w list

- Replace repo and path settings with a single url in settings.yml
- Update VCR filters to use consolidated github URI
- Update cassette to mask full github API URL for allow list
  • Loading branch information
ojbucao committed Feb 18, 2025
1 parent 2c52906 commit 9be044e
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 5 deletions.
3 changes: 1 addition & 2 deletions config/settings.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1747,8 +1747,7 @@ accredited_representative_portal:
allow_list:
github:
access_token: ~
repo: ~
path: ~
uri: ~

banners:
drupal_username: banners_api
Expand Down
3 changes: 1 addition & 2 deletions spec/support/vcr.rb
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,7 @@
c.filter_sensitive_data('<ARP_ALLOW_LIST_ACCESS_TOKEN>') do
Settings.accredited_representative_portal.allow_list.github.access_token
end
c.filter_sensitive_data('<ARP_ALLOW_LIST_REPO>') { Settings.accredited_representative_portal.allow_list.github.repo }
c.filter_sensitive_data('<ARP_ALLOW_LIST_PATH>') { Settings.accredited_representative_portal.allow_list.github.path }
c.filter_sensitive_data('<ARP_ALLOW_LIST_GITHUB_URI>') { Settings.accredited_representative_portal.allow_list.github.uri }

Check failure on line 57 in spec/support/vcr.rb

View workflow job for this annotation

GitHub Actions / Linting and Security

Layout/LineLength: Line is too long. [124/120]
c.before_record do |i|
%i[response request].each do |env|
next unless i.send(env).headers.keys.include?('Token')
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 9be044e

Please sign in to comment.