Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ARP - lower camel responses - 2] camel case POA form persistence #20622

Merged
merged 3 commits into from
Feb 7, 2025
Merged

[ARP - lower camel responses - 2] camel case POA form persistence #20622

merged 3 commits into from
Feb 7, 2025

Conversation

nihil2501
Copy link
Contributor

@nihil2501 nihil2501 commented Feb 5, 2025 •
edited
Loading

See head of PR stack: #20621

@nihil2501 nihil2501 changed the title Art/lower camel responses/2 [ARP - lower camel responses - 2] camel case POA form persistence Feb 5, 2025
@va-vfs-bot va-vfs-bot temporarily deployed to art/lower-camel-responses/2/main/main February 5, 2025 17:08 Inactive
@nihil2501 nihil2501 mentioned this pull request Feb 5, 2025
Merged
@nihil2501 nihil2501 force-pushed the art/lower-camel-responses/1 branch from a767000 to 7f5c32c Compare February 6, 2025 00:54
@nihil2501 nihil2501 force-pushed the art/lower-camel-responses/2 branch from 0280cfd to e406275 Compare February 6, 2025 00:55
@va-vfs-bot va-vfs-bot temporarily deployed to art/lower-camel-responses/2/main/main February 6, 2025 00:57 Inactive
@nihil2501 nihil2501 marked this pull request as ready for review February 7, 2025 22:33
@nihil2501 nihil2501 requested review from a team as code owners February 7, 2025 22:33
@nihil2501
[ARP - lower camel responses - 3] handle camel params in ARP IPF cont…
f544157 
…roller (#20623)

* [ARP] handle camel params in ARP IPF controller

* [ARP - lower camel responses - 4] camel response in ARP users controller (#20624)

* [ARP] camel response in ARP users controller

* [ARP - lower camel responses - 5] bypass olive branch (#20625)

* [ARP] bypass olive branch

* lint fixes
@nihil2501 nihil2501 merged commit 16d1459 into art/lower-camel-responses/1 Feb 7, 2025
8 of 9 checks passed
@nihil2501 nihil2501 deleted the art/lower-camel-responses/2 branch February 7, 2025 22:37
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2025

1 Warning
⚠️ This PR changes 285 LoC (not counting whitespace/newlines).

In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding
200. Expect some delays getting reviews.

File Summary

Files

  • modules/accredited_representative_portal/app/controllers/accredited_representative_portal/v0/in_progress_forms_controller.rb (+1/-1)

  • modules/accredited_representative_portal/app/controllers/accredited_representative_portal/v0/representative_users_controller.rb (+7/-7)

  • modules/accredited_representative_portal/app/models/accredited_representative_portal/power_of_attorney_form.rb (+38/-38)

  • modules/accredited_representative_portal/config/initializers/bypass_olive_branch.rb (+17/-0)

  • modules/accredited_representative_portal/spec/factories/power_of_attorney_form.rb (+42/-42)

  • modules/accredited_representative_portal/spec/factories/representative_user.rb (+5/-1)

  • modules/accredited_representative_portal/spec/requests/accredited_representative_portal/bypass_olive_branch_spec.rb (+38/-0)

  • modules/accredited_representative_portal/spec/requests/accredited_representative_portal/v0/in_progress_forms_spec.rb (+11/-14)

  • modules/accredited_representative_portal/spec/requests/accredited_representative_portal/v0/user_spec.rb (+8/-15)

    Note: We exclude files matching the following when considering PR size:

    *.csv, *.json, *.tsv, *.txt, *.md, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru, *.pdf

Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

nihil2501 added a commit that referenced this pull request Feb 11, 2025
@nihil2501
[ARP - lower camel responses - 1] set_key_transform :camel_lower (#…
adf715c 
…20621)

* [ARP] `set_key_transform :camel_lower`

* lint fixes

* [ARP - lower camel responses - 2] camel case POA form persistence (#20622)

* [ARP] camel case POA form persistence

* lint fixes

* [ARP - lower camel responses - 3] handle camel params in ARP IPF controller (#20623)

* [ARP] handle camel params in ARP IPF controller

* [ARP - lower camel responses - 4] camel response in ARP users controller (#20624)

* [ARP] camel response in ARP users controller

* [ARP - lower camel responses - 5] bypass olive branch (#20625)

* [ARP] bypass olive branch

* lint fixes
ojbucao pushed a commit that referenced this pull request Feb 11, 2025
@nihil2501 @ojbucao
[ARP - lower camel responses - 1] set_key_transform :camel_lower (#…
a115a22 
…20621)

* [ARP] `set_key_transform :camel_lower`

* lint fixes

* [ARP - lower camel responses - 2] camel case POA form persistence (#20622)

* [ARP] camel case POA form persistence

* lint fixes

* [ARP - lower camel responses - 3] handle camel params in ARP IPF controller (#20623)

* [ARP] handle camel params in ARP IPF controller

* [ARP - lower camel responses - 4] camel response in ARP users controller (#20624)

* [ARP] camel response in ARP users controller

* [ARP - lower camel responses - 5] bypass olive branch (#20625)

* [ARP] bypass olive branch

* lint fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chumpy chumpy chumpy approved these changes

@pixiitech pixiitech pixiitech approved these changes

@ojbucao ojbucao Awaiting requested review from ojbucao

Assignees
No one assigned
Labels
benefits-accredited-rep-facing require-backend-approval test-passing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nihil2501 @chumpy @pixiitech @va-vfs-bot