Submission Status Job: Assign lighthouse_updated_at before running callbacks upon state change #20658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…llbacks upon state change
wayne-weibel
requested changes
Feb 6, 2025
| @@ -152,7 +153,7 @@ def update_attempt_record(uuid, status, submission) | |||
| form_submission_attempt.vbms! | |||
| end | |||
|
|
|||
| form_submission_attempt.update(lighthouse_updated_at:, error_message:) | |||
| form_submission_attempt.update(error_message:) if error_message | |||
There was a problem hiding this comment.
Drop the conditional, there should only be an error_message if the attempt is in the failure state
va-vfs-bot
temporarily deployed
to
benefits_intake_submission_status_job_bugfix/main/main
wayne-weibel
approved these changes
Feb 6, 2025
rmtolmach
approved these changes
Feb 6, 2025
pennja
approved these changes
Feb 7, 2025
wayne-weibel
deleted the
benefits_intake_submission_status_job_bugfix
branch
holdenhinkle
pushed a commit
that referenced
this pull request
Feb 12, 2025
…llbacks upon state change (#20658)
patrick-brown-oddball
pushed a commit
that referenced
this pull request
Feb 17, 2025
…llbacks upon state change (#20658)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a small bug where we would update state on a
FormSubmissionAttempt(triggering an email to send) before populating thelighthouse_updated_atfield. The emails, without this field set, would fail. Currently this whole Job is behind a feature flag (:benefits_intake_submission_status_job) which is OFF. Once we fix this, I believe we are safe to turn the feature flag back on.