Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API-44936-e-benefits-service-missing-require #20766

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

stiehlrod
Copy link
Contributor

Summary

  • Adds missing require statement.
  • Adds a test, and cassette.

Related issue(s)

Testing done

  • New code is covered by unit tests

What areas of the site does it impact?

modified:   modules/claims_api/app/services/claims_api/dependent_claimant_poa_assignment_service.rb
modified:   modules/claims_api/spec/services/dependent_claimant_poa_assignment_service_spec.rb
new file:   spec/support/vcr_cassettes/claims_api/bgs/e_benefits_bnft_claim_status_web/find_benefit_claims_status_by_ptcpnt_id.yml

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@stiehlrod stiehlrod self-assigned this Feb 12, 2025
@stiehlrod stiehlrod requested a review from a team as a code owner February 12, 2025 17:47
@stiehlrod stiehlrod changed the title Adds missing require statement. Adds a test, and cassette. API-44936-e-benefits-service-missing-require Feb 12, 2025
…ts-api into API-44936-e-benefits-service-missing-require

merges master
…error to be reproduced in the tests. I removed those in the tests, added the missing require in the service, and added more tests.
@stiehlrod stiehlrod marked this pull request as draft February 18, 2025 17:49
….com:department-of-veterans-affairs/vets-api into API-44936-e-benefits-service-missing-require

merges remote
@stiehlrod stiehlrod marked this pull request as ready for review February 18, 2025 17:50
Copy link
Contributor

@rockwellwindsor-va rockwellwindsor-va left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants