Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip timezone from POST params #20790

Merged
merged 14 commits into from
Feb 19, 2025
Merged

Conversation

kjduensing
Copy link
Contributor

Summary

  • This work is behind a feature toggle (flipper): YES

Related issue(s)

Closes department-of-veterans-affairs/va.gov-team#102843

Testing done

  • New code is covered by unit tests

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected

@va-vfs-bot va-vfs-bot temporarily deployed to btsss/strip-tz-from-submission-param/main/main February 13, 2025 17:56 Inactive
liztownd
liztownd previously approved these changes Feb 13, 2025
Copy link
Contributor

@liztownd liztownd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you've got a linting error, but otherwise looks good!

@va-vfs-bot va-vfs-bot temporarily deployed to btsss/strip-tz-from-submission-param/main/main February 13, 2025 19:23 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to btsss/strip-tz-from-submission-param/main/main February 13, 2025 20:28 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to btsss/strip-tz-from-submission-param/main/main February 13, 2025 20:41 Inactive
seesleestak
seesleestak previously approved these changes Feb 13, 2025
@va-vfs-bot va-vfs-bot temporarily deployed to btsss/strip-tz-from-submission-param/main/main February 13, 2025 21:11 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to btsss/strip-tz-from-submission-param/main/main February 13, 2025 21:41 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to btsss/strip-tz-from-submission-param/main/main February 13, 2025 22:00 Inactive
@kjduensing kjduensing marked this pull request as ready for review February 13, 2025 23:22
@kjduensing kjduensing requested review from a team as code owners February 13, 2025 23:22
seesleestak
seesleestak previously approved these changes Feb 18, 2025
@kjduensing kjduensing requested a review from a team as a code owner February 18, 2025 19:01
@va-vfs-bot va-vfs-bot temporarily deployed to btsss/strip-tz-from-submission-param/main/main February 18, 2025 19:02 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to btsss/strip-tz-from-submission-param/main/main February 18, 2025 19:04 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to btsss/strip-tz-from-submission-param/main/main February 18, 2025 19:05 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to btsss/strip-tz-from-submission-param/main/main February 18, 2025 19:20 Inactive
Copy link
Contributor

@stevenjcumming stevenjcumming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider moving DateUtils and the other non-client models in /services to modules/travel_pay/lib/travel_pay in another PR

@kjduensing kjduensing merged commit 6a7fbb7 into master Feb 19, 2025
22 of 26 checks passed
@kjduensing kjduensing deleted the btsss/strip-tz-from-submission-param branch February 19, 2025 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Match appts to claims on local time
5 participants