Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CC Referral appointments - Get EPS Appointment by ID #20792

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

devin-mccurdy
Copy link
Contributor

@devin-mccurdy devin-mccurdy commented Feb 13, 2025

Summary

  • Added a new endpoint to that VAOS module that returns an EPS appointment along with provider data based for an EPS appointment ID.
  • I added a new controller instead of ignoring a rubocop ClassLength rule on the AppointmentsController. I also standardized casing of hash keys to match the rest of the VAOS app, so now hash keys are snake-cased and we're relying on Faraday and Rails to camel-case where needed.

Related issue(s)

Testing done

  • New code is covered by unit tests

What areas of the site does it impact?

  • This is a new endpoint and doesn't have an impact on any existing functionality

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Documentation has been updated (link to documentation)

Copy link

1 Warning
⚠️ This PR changes 456 LoC (not counting whitespace/newlines).

In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding
200. Expect some delays getting reviews.

File Summary

Files

  • modules/vaos/app/controllers/vaos/v2/appointments_controller.rb (+4/-4)

  • modules/vaos/app/controllers/vaos/v2/eps_appointments_controller.rb (+39/-0)

  • modules/vaos/app/serializers/eps/draft_appointment_serializer.rb (+7/-7)

  • modules/vaos/app/serializers/eps/eps_appointment_serializer.rb (+26/-0)

  • modules/vaos/app/services/eps/appointment_service.rb (+5/-5)

  • modules/vaos/app/services/eps/base_service.rb (+2/-2)

  • modules/vaos/app/services/eps/configuration.rb (+2/-0)

  • modules/vaos/config/routes.rb (+1/-0)

  • modules/vaos/spec/controllers/v2/providers_controller_spec.rb (+5/-4)

  • modules/vaos/spec/requests/vaos/v2/appointments_spec.rb (+2/-2)

  • modules/vaos/spec/requests/vaos/v2/eps_appointments_spec.rb (+100/-0)

  • modules/vaos/spec/serializers/eps/draft_appointment_serializer_spec.rb (+34/-34)

  • modules/vaos/spec/serializers/eps/eps_appointment_serializer_spec.rb (+151/-0)

  • modules/vaos/spec/services/eps/appointment_service_spec.rb (+9/-9)

  • modules/vaos/spec/services/eps/base_service_spec.rb (+1/-1)

    Note: We exclude files matching the following when considering PR size:

    *.csv, *.json, *.tsv, *.txt, *.md, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru, *.pdf
    

Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

Copy link
Contributor

@PhilipDeFraties PhilipDeFraties left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devin-mccurdy devin-mccurdy marked this pull request as ready for review February 18, 2025 16:03
@devin-mccurdy devin-mccurdy requested review from a team as code owners February 18, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants