Travel Pay / Add statsd logging

[liztownd]

Summary

• This work is behind a feature toggle (flipper): YES/NO No

• (Summarize the changes that have been made to the platform)

  • Adding statsd logging to our external API calls to measure response time

• (What is the solution, why is this the solution?)

  • We need a way to measure how long it takes for each response individually to track latency when calling the external API.
  • We are currently only tracking the latency for the entire process, not each step individually (i.e. getting tokens, then getting the claims takes a ms vs. getting the first token takes x ms, the second token takes y ms and actually getting the claims response takes z ms)

• (Which team do you work for, does your team own the maintenance of this component?)

  • Travel Pay

Related issue(s)

• Link to ticket created in va.gov-team repo OR screenshot of Jira ticket if your team uses Jira
  SMOC xTIC latency measurements va.gov-team#103016

• Link to epic if not included in ticket
  INITIATIVE: Simple Mileage-Only Claims va.gov-team#83829

Testing done

• New code is covered by unit tests
• Describe what the old behavior was prior to the change
• We were logging only the total time to make each call at the controller level, now each individual step can be measured independently
• Describe the steps required to verify your changes are working as expected. Exclusively stating 'Specs run' is NOT acceptable as appropriate testing
• Update unit tests to check that the correct tags/prefixes were being sent to statsd, but I believe we won't know if it's logging correctly until it's merged and we start seeing metrics show up in datadog

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)
Travel Pay module only

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution
• Documentation has been updated (link to documentation)
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Feature/bug has a monitor built into Datadog (if applicable)
• If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
• I added a screenshot of the developed feature

Requested Feedback

I would love feedback as to the statsd prefix and tags we have chosen as we're not 100% sure if this is the best way to go about tracking/sorting/grouping/tagging the different metrics.

[kjduensing]

Awesome work.