Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VEBT: fix failing VYE bdn_ingress test on holidays #20814

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

GcioGregg
Copy link
Contributor

Summary

  • This work is behind a feature toggle (flipper): NO
  • bdn_ingress test was failing because today is a holiday
  • failing test
  • fix logging for when test is run on a holiday
  • VEBT
  • (If introducing a flipper, what is the success criteria being targeted?) N/A

Related issue(s)

Testing done

  • New code is covered by unit tests
  • bdn_ingress test failed
  • check that all tests pass

What areas of the site does it impact?

VYE tests

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)

@GcioGregg GcioGregg merged commit eace10e into master Feb 17, 2025
35 of 36 checks passed
@GcioGregg GcioGregg deleted the vebt-vye-test-ingress_bdn branch February 17, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants