Skip to content

Commit

Permalink
move ShareBuild to the core api instead of build
Browse files Browse the repository at this point in the history
the build API is specifically meant for build orchestration
  • Loading branch information
William Batista authored and William Batista committed Oct 21, 2024
1 parent ccac06d commit 43a7827
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 16 deletions.
16 changes: 0 additions & 16 deletions proto/depot/build/v1/build.proto
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@ package depot.build.v1;
service BuildService {
rpc CreateBuild(CreateBuildRequest) returns (CreateBuildResponse);
rpc FinishBuild(FinishBuildRequest) returns (FinishBuildResponse);
rpc ShareBuild(ShareBuildRequest) returns (ShareBuildResponse);
rpc StopSharingBuild(StopSharingBuildRequest) returns (StopSharingBuildResponse);
}

message CreateBuildRequest {
Expand All @@ -32,17 +30,3 @@ message FinishBuildRequest {
}

message FinishBuildResponse {}

message ShareBuildRequest {
string build_id = 1;
}

message ShareBuildResponse {
string share_url = 1;
}

message StopSharingBuildRequest {
string build_id = 1;
}

message StopSharingBuildResponse {}
20 changes: 20 additions & 0 deletions proto/depot/core/v1/project.proto
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,12 @@ service ProjectService {

// Delete project API token.
rpc DeleteToken(DeleteTokenRequest) returns (DeleteTokenResponse) {}

// Share a URL to a build with users outside of your organization
rpc ShareBuild(ShareBuildRequest) returns (ShareBuildResponse);

// Stop sharing a build
rpc StopSharingBuild(StopSharingBuildRequest) returns (StopSharingBuildResponse);
}

message Project {
Expand Down Expand Up @@ -214,3 +220,17 @@ message DeleteTokenRequest {
}

message DeleteTokenResponse {}

message ShareBuildRequest {
string build_id = 1;
}

message ShareBuildResponse {
string share_url = 1;
}

message StopSharingBuildRequest {
string build_id = 1;
}

message StopSharingBuildResponse {}

0 comments on commit 43a7827

Please sign in to comment.