feat(get-xpath): return proper relative selector for id #4846
+96
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbjorge
previously approved these changes
Aug 7, 2025
There was a problem hiding this comment.
This looks right to me (modulo a nit about improving the tests that you can choose whether to prioritize or not), but asked @WilcoFiers to double check my thinking on the implementation change.
I could see an argument that this should be treated as a breaking change, but I think I'd probably lean towards treating it as a bugfix.
WilcoFiers
previously approved these changes
Aug 7, 2025
straker
changed the title
dbjorge
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #4845