fix(react): Make RadioItem public
#1668
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An application I'm working on requires using the `RadioItem` type directly, but the type is not exported from the package's entrypoint. This patch makes `RadioItem` part of the public API.
Previously, to get access to `RadioItem`, users would have to:
```ts
import {RadioItem} from "@deque/cauldron-react/lib/components/RadioGroup"
```
This is brittle (will break if we rename files/etc.) and doesn't look nearly as nice.
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
scurker
reviewed
Sep 13, 2024
There was a problem hiding this comment.
We typically have not been exporting the types from components, and don't really think we should do one offs without thinking about how this impacts our public api. Do you mind writing an RFC proposing why we should make this change?
|
This pull request has been open for 30 days with no activity. If no further activity occurs, it will be closed in 14 days. |
github-actions
bot
added
the
stale
|
This pull request was closed because it has been inactive for 14 days since being marked as stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An application I'm working on requires using the
RadioItemtype directly, but the type is not exported from the package's entrypoint. This patch makesRadioItempart of the public API.Previously, to get access to
RadioItem, users would have to:This is brittle (will break if we rename files/etc.) and doesn't look nearly as nice.