Add timeout option #239
Add timeout option #239
Conversation
threema-donat
force-pushed
the
add_timeout_option
branch
from
6da4931 to
2e0c943
Compare
threema-donat
force-pushed
the
add_timeout_option
branch
from
2e0c943 to
82ce134
Compare
Since the test and actual fn definition are equal and HTTP is allowed in every case, the test function is not needed anymore
Resolves warnings when creating docs and therefore makes failure on warning possible
threema-donat
force-pushed
the
add_timeout_option
branch
from
a65fa00 to
9d09d5b
Compare
|
I have pushed some commits that resolve warnings and added a job to run clippy linting to the CI pipeline. Furthermore, I disallowed warnings when they occur in the jobs. Please let me know if you want to have this as a separate PR. Be aware that I renamed the config |
|
Very nice! I like the new types, the weird hyper legacy client thing got on my nerves by now. I noticed that |
src/authenticator.rs
Outdated
| @@ -988,7 +994,61 @@ pub type DefaultAuthenticator = | |||
| yup_oauth2_docsrs, | |||
| doc(cfg(any(feature = "hyper-rustls", feature = "hyper-tls"))) | |||
| )] | |||
| pub struct DefaultHyperClient; | |||
| #[derive(Default)] | |||
There was a problem hiding this comment.
maybe move this to the client module as well? It looks general enough to make sense there.
There was a problem hiding this comment.
True! I moved the DefaultHyperClient as well as the CustomHyperClient to the client module and appended Builder to them.
threema-donat
force-pushed
the
add_timeout_option
branch
3 times, most recently
from
65dea01 to
ef846b6
Compare
threema-donat
force-pushed
the
add_timeout_option
branch
from
ef846b6 to
ff1ffe9
Compare
threema-donat
force-pushed
the
add_timeout_option
branch
2 times, most recently
from
8b08db7 to
0d7dad9
Compare
threema-donat
force-pushed
the
add_timeout_option
branch
from
0d7dad9 to
d61b4cb
Compare
Adds the option to add a timeout after which a request will fail. PR #238 should be reviewed before this