-
Notifications
You must be signed in to change notification settings - Fork 0
Day 4 — Patient Detail Page, Visit History & Appointments #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
f831463
Fix CodeRabbit issues: genetics type mismatch, migration script passw…
deshanekanayaka e24ef58
Day 4: patient detail page, visit history, appointments, ML fixes
deshanekanayaka 80505c7
Fix CodeRabbit flagged issues: validation, duplicate submission guard…
deshanekanayaka File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add
BACKEND_ORIGINto backend env docs to prevent CORS setup failures.The backend env reference omits
BACKEND_ORIGIN, but the frontend runs onhttp://localhost:5173and the ML service default origin is stillhttp://localhost:3000. Fresh local setups can fail CORS unless this is explicitly configured.Suggested doc patch
### Backend | Variable | Description | |----------|-------------| | `PORT` | Server port (default 3300) | | `DB_HOST` | MySQL host | | `DB_USER` | MySQL user | | `DB_PASSWORD` | MySQL password | | `DB_NAME` | Database name (diacify_db) | | `DB_PORT` | MySQL port (default 3306) | | `ML_SERVICE_URL` | URL of the ML FastAPI service | +| `BACKEND_ORIGIN` | Allowed frontend origin for ML CORS (e.g. `http://localhost:5173`) | | `CLERK_SECRET_KEY` | Clerk backend secret key | | `ML_INTERNAL_SECRET` | Shared secret for ML service authentication |🧰 Tools
🪛 markdownlint-cli2 (0.22.1)
[warning] 314-314: Tables should be surrounded by blank lines
(MD058, blanks-around-tables)
🤖 Prompt for AI Agents