Refactor: Centralize Markdown table Tailwind CSS classes in config file #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refactors the custom Markdown table renderers to fetch their Tailwind CSS class strings from a dedicated configuration file (`config/tailwind_tables.php`) instead of having them hardcoded. Key changes: - Created `config/tailwind_tables.php` to store all Tailwind CSS classes for different table elements (wrapper, table, thead, tbody_row, th_head, th_body_row_header, td_cell). - Updated `TailwindTableRenderer.php`, `TailwindTableSectionRenderer.php`, `TailwindTableRowRenderer.php`, and `TailwindTableCellRenderer.php` to use Laravel's `config()` helper to retrieve these classes. - Fallback values (the original hardcoded classes) are provided in the `config()` calls to ensure stability if the config file or keys are missing. This change improves maintainability by making it easier to view and modify table styles from a single, centralized location.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors the custom Markdown table renderers to fetch their Tailwind CSS class strings from a dedicated configuration file (
config/tailwind_tables.php) instead of having them hardcoded.Key changes:
config/tailwind_tables.phpto store all Tailwind CSS classes for different table elements (wrapper, table, thead, tbody_row, th_head, th_body_row_header, td_cell).TailwindTableRenderer.php,TailwindTableSectionRenderer.php,TailwindTableRowRenderer.php, andTailwindTableCellRenderer.phpto use Laravel'sconfig()helper to retrieve these classes.config()calls to ensure stability if the config file or keys are missing.This change improves maintainability by making it easier to view and modify table styles from a single, centralized location.