Scale Lyman-series A by line / LyA_wavelength - #355
Draft
shaneraphel wants to merge 1 commit into
Draft
shaneraphel wants to merge 1 commit into
shaneraphel wants to merge 1 commit into
Conversation
Calura12 higher-order A was leftover f_n/f_Lya only. Optical depth scales as lambda_n f_n / (lambda_alpha f_alpha), and leftover already stores each line.
shaneraphel
changed the title
Collaborator
|
External from DESI contribution. Wait until after Nevis before reviewing. |
sbailey
marked this pull request as draft
September 21, 2026 17:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calura12
Afor Lyβ…Ly5 isA_Lya / (f_Lya / f_n)— oscillator strength only. Lyman-series optical depth scales as λ_n f_n / (λ_α f_α), and each row already storesline.Ais nowA_Lya * (line / LyA_wavelength) / (f_Lya / f_n)on those four rows. Kamble20 comments stay commented. Inoue14 tables are unchanged.Fixes #333