reworked spacer logic according to ISO 80000-1:2022 #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
according to ISO 80000-1:2022, even abbreviated units have a non-breaking space
- Simplify spacer logic in prettyDuration function using ternary operators
- Add abbreviatedSpacer property to DurationLocale base class and all locale implementations
- Change default spacer from regular space to non-breaking space (\u{00A0})
- Update all test expectations to use non-breaking space character
- Add new English US locale implementation
Alphabetized part imports and locale constant declarations to improve code organization and maintainability. This change makes it easier to locate specific locales and ensures consistent ordering throughout the codebase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.