add CI for linux ARM64 and ARMhf#32
Open
theofficialgman wants to merge 2 commits intodesktop:mainfrom
Open
Conversation
Author
|
CC @shiftkey edit: though this isn't strictly necessary since the builds complete just fine at build time of github desktop |
theofficialgman
changed the title
theofficialgman
commented
Jul 8, 2023
Comment on lines
+44
to
+46
| "resolutions": { | ||
| "node-gyp": "^9.4.0" | ||
| }, |
Author
There was a problem hiding this comment.
this is required due to prebuild rotting and not upping their dependencies. it currently depends on node-gpy v6.0.0 which has build issues with python-3.11 (that multiple of the github runners now use)
v9.0.0 is api compatible so we force it. upstream bug long reported here prebuild/prebuild#286
theofficialgman
commented
Jul 8, 2023
Comment on lines
+91
to
+94
| - name: Prebuild (arm64) on Ubuntu | ||
| if: matrix.friendlyName == 'Ubuntu' | ||
| run: CC=aarch64-linux-gnu-gcc LINK=aarch64-linux-gnu-gcc STRIP=aarch64-linux-gnu-strip yarn prebuild-napi-arm64 | ||
| - name: Prebuild (arm) on Ubuntu | ||
| if: matrix.friendlyName == 'Ubuntu' | ||
| run: CC=arm-linux-gnueabihf-gcc LINK=arm-linux-gnueabihf-gcc STRIP=arm-linux-gnueabihf-strip yarn prebuild-napi-arm |
Author
There was a problem hiding this comment.
as noted elsewhere, node-gyp is used here for compilation and doesn't support cross compilation on linux. so we override CC/LINK/STRIP with the appropriate cross compilers ourselves
so that github-desktop linux fork has a chance to use these prebuilts
Author
|
add a small speed optimization. good for merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also bump version to 0.9.9
bumps various dependencies as well as necessary to build. it has been over a year since this action ran and it was failing in multiple places due to deprecations at various upstreams