Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add users from VLIZ #93

Merged
merged 5 commits into from
Oct 23, 2024
Merged

add users from VLIZ #93

merged 5 commits into from
Oct 23, 2024

Conversation

tinaok
Copy link
Collaborator

@tinaok tinaok commented Oct 21, 2024

We will start to use add more users.
How do we want to proceed?

Can we make a procedure for clearing new users?

@tinaok tinaok requested review from minrk and annefou October 23, 2024 06:04
@annefou
Copy link
Collaborator

annefou commented Oct 23, 2024

@tinaok What level of access does davidcasalsVLIZ need for the S3 buckets?

Read-only access to the gfts-reference-data and destine-gfts-data-lake S3 buckets? Or is there a need for write access as well?

What about the Ifremer bucket? Does he need read/write access to the gfts-ifremer bucket?

@tinaok
Copy link
Collaborator Author

tinaok commented Oct 23, 2024

Thank you Anne,

Read-only access to the gfts-reference-data and destine-gfts-data-lake S3 buckets? Or is there a need for write access as well?
yes, read only there.

@annefou
Copy link
Collaborator

annefou commented Oct 23, 2024

@minrk I tried to add the new buckets gfts-vliz and vliz_users. Could you check if everything is set up correctly, and that I haven’t messed up anything? Thanks!

@minrk
Copy link
Collaborator

minrk commented Oct 23, 2024

Can we make a procedure for clearing new users?

We do have a procedure here.

We can add docs for creating the buckets for new users.

@annefou looks right! I noticed a couple things that needed fixing in #93, and I'll apply those here as well (mainly a default deny permission that seems like it is supposed to be the s3 default, but isn't when I test).

@annefou
Copy link
Collaborator

annefou commented Oct 23, 2024

We can add docs for creating the buckets for new users.

Do you mean that gfts-vliz needs to be created manually and separately?
Or do you mean I should document the process of adding a new bucket in the doc https://destination-earth.github.io/DestinE_ESA_GFTS/admin_hub.html ?

@minrk
Copy link
Collaborator

minrk commented Oct 23, 2024

Do you mean that gfts-vliz needs to be created manually and separately?

No, I mean what you did in this PR, which was exactly right, it is just a lot of copying and pasting we haven't written down yet.

I think it can actually be simplified a bit, too.

@minrk
Copy link
Collaborator

minrk commented Oct 23, 2024

Any more you want to do here, or ok to merge?

@annefou
Copy link
Collaborator

annefou commented Oct 23, 2024

For me it is OK to merge.

@minrk minrk merged commit e8376a4 into main Oct 23, 2024
1 check passed
@minrk minrk deleted the add_VLIZ branch October 23, 2024 12:27
@minrk
Copy link
Collaborator

minrk commented Oct 23, 2024

ok, the bucket exists and the user should have access to the Hub when the github action finishes deploying

@annefou
Copy link
Collaborator

annefou commented Oct 23, 2024

Perfect! I will add some info on adding new buckets in the doc. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants