Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify s3 permissions a bit more #96

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Conversation

minrk
Copy link
Collaborator

@minrk minrk commented Oct 23, 2024

  • remove ACLs on other than the allow-all-authenticated, as they are redundant with (and less effective) than user policies
  • consolidate common policy (read access to public + deny bucket creation) to a variable we can reuse (less copy/paste to make new buckets)
  • add test to exercise everyone's s3 permissions to make sure they are correct

@annefou this simplifies creating a new group/bucket because it only needs to create the user policy and the user policy only needs to specify the write permissions, as the read/deny permissions are shared through a variable

- remove ACLs on other than the allow-all-authenticated
- consolidate common policy to a variable we can reuse (less copy/paste)
- add test to exercise everyone's s3 permissions to make sure it's correct
@minrk minrk requested a review from annefou October 23, 2024 14:19
@annefou
Copy link
Collaborator

annefou commented Oct 23, 2024

Nice! How gfts-track-reconstruction/jupyterhub/tofu/tests/test_permissions.py should be run? Do we need to run it manually after tofu apply or is it run automatically?

@minrk
Copy link
Collaborator Author

minrk commented Oct 23, 2024

Yes, run pytest in the tofu directory after tofu apply

@annefou annefou merged commit d5333a0 into destination-earth:main Oct 23, 2024
1 check passed
@minrk minrk deleted the simpl2 branch October 23, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants