Skip to content

Conversation

@github-actions
Copy link

Backport 6feaddf from #10203.

@github-actions github-actions bot requested review from a team as code owners November 13, 2024 21:44
@github-actions github-actions bot requested review from ashtonG and mackrorysd and removed request for a team November 13, 2024 21:44
@cla-bot cla-bot bot added the cla-signed label Nov 13, 2024
@codecov
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 8.00000% with 23 lines in your changes missing coverage. Please review.

Project coverage is 54.53%. Comparing base (50b7690) to head (2134d09).
Report is 1 commits behind head on release-0.38.0.

Files with missing lines Patch % Lines
.../react/src/pages/TrialDetails/TrialDetailsLogs.tsx 10.00% 18 Missing ⚠️
master/internal/api_tasks.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           release-0.38.0   #10205      +/-   ##
==================================================
+ Coverage           54.32%   54.53%   +0.21%     
==================================================
  Files                1259     1258       -1     
  Lines              157328   156512     -816     
  Branches             3642     3643       +1     
==================================================
- Hits                85466    85356     -110     
+ Misses              71729    71023     -706     
  Partials              133      133              
Flag Coverage Δ
backend 46.08% <0.00%> (+0.01%) ⬆️
harness 71.14% <ø> (ø)
web 54.73% <10.00%> (+0.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
master/internal/api_trials.go 57.22% <ø> (-0.05%) ⬇️
master/internal/db/postgres_filters.go 46.57% <ø> (-6.76%) ⬇️
master/internal/elastic/elastic_task_logs.go 0.00% <ø> (ø)
webui/react/src/services/decoder.ts 21.34% <ø> (+0.02%) ⬆️
webui/react/src/types.ts 99.70% <ø> (-0.01%) ⬇️
master/internal/api_tasks.go 50.20% <0.00%> (-2.16%) ⬇️
.../react/src/pages/TrialDetails/TrialDetailsLogs.tsx 15.86% <10.00%> (+4.75%) ⬆️

... and 9 files with indirect coverage changes

---- 🚨 Try these New Features:

@mackrorysd mackrorysd merged commit e693655 into release-0.38.0 Nov 18, 2024
@mackrorysd mackrorysd deleted the backport-10203-to-release-0.38.0 branch November 18, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants